bug(opensearch-sink) Setting 'insecure' should override 'cert' #5268
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhoy
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Jan Høydahl <[email protected]>
janhoy
force-pushed
the
insecure-overrides-certpath
branch
from
e9797f2 to
2a58b26
Compare
janhoy
commented
Dec 17, 2024
| @@ -118,7 +118,7 @@ Default is null. | |||
|
|
|||
| - `aws_sts_header_overrides`: An optional map of header overrides to make when assuming the IAM role for the sink plugin. | |||
|
|
|||
| - `insecure`: A boolean flag to turn off SSL certificate verification. If set to true, CA certificate verification will be turned off and insecure HTTP requests will be sent. Default to `false`. | |||
| - `insecure`: A boolean flag to turn off SSL certificate verification. If set to true, CA certificate verification will be turned off and insecure HTTP requests will be sent. Setting this will override any `cert` configured. Default to `false`. | |||
There was a problem hiding this comment.
I added the same documentation clarification on the source side as on the sink side. Peeking in the configuration code for source, it appears that insecure: true already overrides cert, so this is just a clarification.
janhoy
commented
Dec 17, 2024
| builder = builder.withInsecure(insecure); | ||
| // Insecure == true will override configured certPath | ||
| if (insecure) { | ||
| builder.withInsecure(insecure); |
There was a problem hiding this comment.
I found no way to log a warning if both options are configured at the same time, so this is just a silent override.
janhoy
changed the title
san81
approved these changes
Jan 9, 2025
jcrean
pushed a commit
to jcrean/data-prepper
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Jan Høydahl <[email protected]> Signed-off-by: Josh Crean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR flips the precedence between
certandinsecureconfig options so thatinsecure: trueoverrides the presence ofcert.Issues Resolved
Resolves #5267
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.